Skip to content

chore(perf): deprecations for v8 API ahead of future major release #8585

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 1, 2025
Merged

chore(perf): deprecations for v8 API ahead of future major release #8585

merged 1 commit into from
Jul 1, 2025

Conversation

MichaelVerdon
Copy link
Collaborator

Description

Related issues

Release Summary

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
    • Yes
  • My change supports the following platforms;
    • Android
    • iOS
    • Other (macOS, web)
  • My change includes tests;
    • e2e tests added or updated in packages/\*\*/e2e
    • jest tests added or updated in packages/\*\*/__tests__
  • I have updated TypeScript types that are affected by my change.
  • This is a breaking change;
    • Yes
    • No

Test Plan

Think react-native-firebase is great? Please consider supporting the project with any of the below:

@vercel Vercel
Copy link

vercel bot commented Jun 23, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-native-firebase ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 1, 2025 7:37pm

@MichaelVerdon MichaelVerdon marked this pull request as ready for review June 23, 2025 15:41
russellwheatley
russellwheatley requested changes Jun 24, 2025
View reviewed changes
Copy link
Member

@russellwheatley russellwheatley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should make these three settable from initialisePerformance():
https://github.com/invertase/react-native-firebase/blob/main/packages/perf/lib/index.js#L55-L103

dataCollectionEnabled and isPerformanceCollectionEnabled are the same. The moduler method of initialisePerformance() needs to be updated. See JS docs for the options:

https://firebase.google.com/docs/reference/js/performance.md?_gl=1*wajhyu*_up*MQ..*_ga*NTg3Mjc2MzMuMTc1MDc1MzIxMQ..*_ga_CW55HF8NVT*czE3NTA3NTMyMTAkbzEkZzAkdDE3NTA3NTMyMTAkajYwJGwwJGgw#initializeperformance_980350e

MichaelVerdon
MichaelVerdon commented Jun 24, 2025
View reviewed changes
russellwheatley
russellwheatley requested changes Jun 24, 2025
View reviewed changes
@mikehardy mikehardy force-pushed the performance-deprecations branch from df98cef to b67d0df Compare July 1, 2025 12:44
mikehardy
mikehardy approved these changes Jul 1, 2025
View reviewed changes
Copy link
Collaborator

@mikehardy mikehardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! LGTM - squashed it down to a single commit, rebased it to main to make sure it's up to date for CI and pending merge if CI goes green

@mikehardy mikehardy added the Workflow: Pending Merge Waiting on CI or similar label Jul 1, 2025
@mikehardy mikehardy force-pushed the performance-deprecations branch from b67d0df to 7f237d0 Compare July 1, 2025 19:22
@mikehardy mikehardy merged commit 42f7194 into main Jul 1, 2025
15 of 16 checks passed
@mikehardy mikehardy deleted the performance-deprecations branch July 1, 2025 19:22
@mikehardy mikehardy removed the Workflow: Pending Merge Waiting on CI or similar label Jul 1, 2025
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@mikehardy mikehardy mikehardy approved these changes

@russellwheatley russellwheatley russellwheatley approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MichaelVerdon @mikehardy @russellwheatley